Talk:Filter and Custom Filter Management Framework for the Nokia Imaging SDK
Hamishwillee - What do you want to call it?
Nice update. I've done a very basic update for wiki style - I will update for English and give you a proper review as soon as I can. BTW, is the source code linked still appropriate, and would it be possible to make this the MIT Licence?
talk) 05:04, 10 December 2013 (EET)(
Engin Kırmacı -
All files and github source were updated and also changed github source licence to MIT Licence.Also the title "Imaging Framework for Nokia Imaging SDK's Filters and Custom Filters" would be nice, I guess.
talk) 09:53, 10 December 2013 (EET)(
I need to take more time to read but in a quick read, you architecture is cool :) Really better than the previous version.
How do you manage IDiposable elements?HistogramFilter could more interesting as renderer, no?
talk) 12:31, 10 December 2013 (EET)(
Engin Kırmacı -
I think, I forgot to manage IDisposable elements :) I'll add method "DisposeSession()" and manage other disposable.Also HistogramFilter as a renderer is a good idea.
talk) 06:47, 11 December 2013 (EET)(
Engin Kırmacı -Yan, thanks for your feedbacks
talk) 06:49, 11 December 2013 (EET)(
Hamishwillee - Thanks
Much appreciated you setting the permissive license - thank you. I've renamed, but not entirely happy with it. How about "Filter and Custom Filter Management Framework for the Nokia Imaging SDK"?
Thanks also Yan for your suggestions!
talk) 07:53, 11 December 2013 (EET)(
Engin Kırmacı -
It's much better than my title. You can change to "Filter and Custom Filter Management Framework for the Nokia Imaging SDK".
talk) 09:22, 11 December 2013 (EET)(
Hamishwillee - Review, but not yet subedit :-)
I am quite "excited" about this article. Lots of potential. I don't pretend to be a programming, windows phone or imaging expert, so please excuse me if the questions are dumb and my statements don't make sense.
In effect what you have done is created an alternative framework or extended framework to the standard pipeline provided by the SDK. If you're going to do that it is important to be comparative.
Firstly, what are the problems with the "default" framework that you're trying to address? Is it hard to define the order of execution. Is it hard to undo filters. Is it hard to do exception handling etc. It may be that it is perfectly possible to do everything with the original framework and this just makes a "common task" easier. That is fine, but it needs to be stated in the introduction. Secondly, when you've identified the problem, you need to state (in the introduction) in very broad but succinct terms what it is that your framework offers to solve these problem. You mention currently that the framework offers "Preprocess and Postprocess filter for custom filter, historize filters etc..." - but I don't know what the benefit of a preprocess filter is as opposed to just having a custom filter and calling it "the first filter".
Moving on from the introduction, "Useful information about custom filters in Nokia imaging SDK" looks like a good section. However I think that IFF it is relevant in the body of the article it is worth adding as Note or as "inline comments" at the points where it is relevant. IFF it is useful information that is not actually relevant during your other examples then it should be kept - however probably as a "Notes" section at the END of the article.
The "Imaging Framework" section is of course the "meat" of the article. My problem here is that you jumped straight into object and code descriptions when I still didn't know what it is that the point offers "in overview". This may be fixed by the update I suggest to the introduction. If not, you might want to re-arrange this to have a more detailed overview first where you explain what the pre-post filters, historiable etc offer.
Another really good trick in terms of "justification" would be to have side by side comparison of your code and the "default" code doing the same thing - showing why yours is better. YOu could have some sections for each major activity someone might want to do. You can do this even before you explain the code, provided you have a very brief overview. Other options include adding a class diagram showing the major elements.
"How to implement custom filters?" looks good, however would I be correct in saying that these are JUST the same as in the original? ie these filters can be used in the original framework and your framework without any change? If so you should split this out into its own article. Then make statement in this original article that custom filters are exactly the same as described in the imaging SDK (provide link) then go further to say that the example code implements 3 filters as shown in article XXXX - where XXXX is a new article you create with this material.
Despite the fact I've said a lot here, most of the work is relatively minor restructure + more clear statement of value.
In terms of specific questions:
- In "Sample Filters",
- the heading before the images is "IPixelManipulation": Why? What has this got to do with the images?
- The images are referred to as "ThresholdFilter", "ColorPaletteFilter", "Pixel Interpolation", but below you have "HistogramFilter", "CornerDetection", "QuadTransformation". What is the relationship between these - ie normally I'd expect text and images to be clearly related
- QuadTransformation (gets quadratic shape using corner points, then transforms shape to rectangular form) - what does that mean? Why is this a post process - what is the visual effect?
- You say "You can't use custom filters as built-in filters." What do you mean?
- You say "You use custom filters as you use FilterEffect. It's ImageConsumer and ImageProvider. So you can pipeline with filter effect." I understand this, but doesn't really help with previous section.
- IDisposable - there was talk in comments of adding this - when do you plan to do so?
If you are able to work on this overnight I may be able to subedit for English tomorrow. I don't want to clash with you so feel free to email me when you start/stop work. I won't be doing anything for another 13 hours or so :-)
talk) 07:58, 12 December 2013 (EET)(
Engin Kırmacı - wooow
I'm very impressed about your review. You pointed weak points, I have to explained those. So that I will work in 10 hours, after that when I finished article, I'll send you an email.
Thanks you for review,Engin
talk) 08:57, 12 December 2013 (EET)(
Hamishwillee - You're most welcome
You're most welcome. Even as a native English speaker it is hard to look objectively at your own work until you've had a break from it. It is also much easier to improve something already written than create in the first place.
Looks like your improvements are coming along nicely.
talk) 01:36, 13 December 2013 (EET)(
Engin Kırmacı -
As we talked before, I separated implementation of custom filters to another article. Sorry about that I'm a bit of late, I told you to finish at the weekend.
Anyway, You can see the new article "Implementations of Custom Filter for the Nokia Imaging SDK"
Have a nice day, Engin KırmacıP.S. I want to inform you with an email but an email failed to delivery to you.
talk) 14:41, 16 December 2013 (EET)(
Hamishwillee - a long time ago
Not as late to get back to me as I am to get back to you.
I think the split was good. This still needs a subedit. I had a good look at the code today and I can see many use cases where this could be useful.
talk) 06:00, 25 February 2014 (EET)(