Talk:How to set WebBrowser control viewport dimensions on Windows Phone
BuildNokia - This is great!
Thanks so much for writing this up, Lee. I'll come back next week and give it a more in-depth read. Have a good weekend.Jen
talk) 02:23, 18 January 2014 (EET)(
Hamishwillee - Subedited/Reviewed
Excellent article. I've given it a subedit primarily for wiki style. The main change is that this is written very like a blog. Typically wiki articles are written very tersely, going to facts rather than covering the "journey". Please check I didn't break anything and confirm you are OK with this change?
In terms of the content, I THINK I understand the images in the visual aid. What I think you have done is have a very big image (1920x1080 resolution) and display it on the 720p Simulator in GDR3. What you'd like is for the whole image to be displayed, properly scaled to the resolution of the phone (as shown in the second image), and this works because you pass in the actual dimensions using your workaround. The first image however doesn't work because using @-ms-viewport rule the viewport is set at about 371 pixels rather than the true screen width. Is that correct? I think this would be better with a real image and the resolutions overlayed.
- what needs to happen to remove "(Until it is edited, please ignore the extra, unnecessary parameters that are pulled out of the URI in the html file.)"?
- Also, do we still need the commented out _screenDpiX value?
- The text says "The new method will not work in GDR2 and older. The following code works for both GDR2 and GDR" These are mutually exclusive - the code works and does not work in GDR2.
In terms of "room for improvement", generally speaking any article is improved by an image/images at the end of the introduction which shows the benefit of the article. In this case I'd be tempted to remove the "Visual aid" section and instead have the images at the end of the introduction. I'd probably also have a "real" image and overlay the resolution boundaries you've put in. Then you can easily show the poor scaling of the first method compared to the great rendering in the second method. This wasn't so obvious to me from the current image.
Hope that all makes sense!
talk) 07:01, 24 January 2014 (EET)(
Hamishwillee - Title alsoMight be also good to change title to "How to set WebBrowser control viewport dimensions on Windows Phone" - mostly this is just a preference/consistency
talk) 07:06, 24 January 2014 (EET)(
BuildNokia - Wow
Reading this article, it's pretty obvious that you're a teacher. This is fantastic. Thank you for taking the time to write this up.
I have no further comments; Hamish's edits covered everything I would have done.Jen
talk) 02:48, 25 January 2014 (EET)(
I made some edits: 1. Removed the DPI commented out code. 2. Fixed the apparent conflict about "working in GDR2". I was referring to the old standby of using RenderSize and ScaleFactor not working with 1080p resolution in GDR3. It is new enough (and easily overlooked for people not testing on 1080p) that I wanted to mention it.As for the images and sample code, I'll reupload some edited ones soon.
talk) 23:16, 25 January 2014 (EET)(
Leemcpherson - Thanks all!
Ok, I think it's complete now. I've edited the solution to remove the unnecessary code that I forgot to remove before. The reference to that code was deleted from the article. I've added background images to the demonstration pictures.FYI, the molecule image (a large protein) was generated on Windows Phone using an ambient occlusion technique in plain old DirectX... and I get pretty good framerates rotating it in real-time. I'm still working on the texturing seams (if you zoom close you can see them). This is a long-term project.
talk) 23:59, 25 January 2014 (EET)(
Leemcpherson - Changing titleI actually don't know how to change the title... feel free to do it yourself if you want it to match other articles.
talk) 03:23, 26 January 2014 (EET)(
BuildNokia - Changed title
Looks great Lee. You've put a lot of time into this.For future reference, you change a title by moving a page. On the toolbar at the top of the page, just to the right of "History", there's a drop-down list. Select "Move" from this list. It's not immediately obvious.
talk) 01:44, 29 January 2014 (EET)(