Namespaces

Variants
Actions

Please note that as of October 24, 2014, the Nokia Developer Wiki will no longer be accepting user contributions, including new entries, edits and comments, as we begin transitioning to our new home, in the Windows Phone Development Wiki. We plan to move over the majority of the existing entries over the next few weeks. Thanks for all your past and future contributions.

(Difference between revisions)

Talk:Edge detection filter in Windows Phone

From Wiki
Jump to: navigation, search
yan_ (Talk | contribs)
(Yan - - Yan -)
somnathbanik (Talk | contribs)
(Somnathbanik - Thanks: new section)
Line 47: Line 47:
 
return bufferOut
 
return bufferOut
 
</code><p style="text-align:right">[[User:Yan|Yan]] ([[User talk:Yan|talk]]) 22:23, 14 December 2013 (EET)</p>
 
</code><p style="text-align:right">[[User:Yan|Yan]] ([[User talk:Yan|talk]]) 22:23, 14 December 2013 (EET)</p>
 +
 +
== Somnathbanik - Thanks ==
 +
 +
Hi Guys,
 +
 +
Thanks for your feedback, I will update the code soon.
 +
 +
 +
Regards
 +
Somnath<p style="text-align:right">[[User:Somnathbanik|Somnathbanik]] ([[User talk:Somnathbanik|talk]]) 13:27, 15 December 2013 (EET)</p>

Revision as of 11:27, 15 December 2013

Contents

Hamishwillee - Very first thought

Hi Somnath

Thanks for the article.

My first thought is that this filter would be much better if created as a custom filter in the Nokia Imaging SDK. That way others could use it in the pipeline and with other filters. Can you modify to support that?

This is a lot like "sketch" filter h- see http://developer.nokia.com/Resources/Library/Imaging_API_Ref/#!index.html

My only other thought is that the UI itself is not as interesting as the filter, so perhaps reorder and discuss the UI only very briefly at end.

I hope to review more thoroughly tomorrow

Regards

H

hamishwillee (talk) 08:09, 12 December 2013 (EET)

Hamishwillee - Still the same feedback

Hi Somnath

I fixed the categories and gave the introduction a subedit to improve the English.

Basically though my feedback is the same. This is an interesting filter, but it's value would be much higher if it was created for use with the Imaging SDK. I'm also more interested in the algorithm and integrating with the SDK than with the specific UI used.

So "high potential", but not yet realised :-)

regards

Hamish

hamishwillee (talk) 02:57, 13 December 2013 (EET)

Yan -

WriteableBitmap properties are slow. You should not use them in your loop. You can do something like

var with = bmp.PixelWidth;
var height = bmp.PixelHeight;
var bufferIn = bmp.Pixels;
var bufferOut = bitmap.Pixels;
for(int i= 0;i<height;++i)
for(int j = 0; j < width; ++j)
{
int index = i*with+j;
bufferOut [index] = bufferIn [index];
 
}
return bufferOut

yan_ (talk) 22:23, 14 December 2013 (EET)

Somnathbanik - Thanks

Hi Guys,

Thanks for your feedback, I will update the code soon.


Regards

Somnath

somnathbanik (talk) 13:27, 15 December 2013 (EET)

 

Was this page helpful?

Your feedback about this content is important. Let us know what you think.

 

Thank you!

We appreciate your feedback.

×