Talk:Edge detection filter in Windows Phone
Hamishwillee - Very first thought
Thanks for the article.
My first thought is that this filter would be much better if created as a custom filter in the Nokia Imaging SDK. That way others could use it in the pipeline and with other filters. Can you modify to support that?
This is a lot like "sketch" filter h- see http://developer.nokia.com/Resources/Library/Imaging_API_Ref/#!index.html
My only other thought is that the UI itself is not as interesting as the filter, so perhaps reorder and discuss the UI only very briefly at end.
I hope to review more thoroughly tomorrow
talk) 08:09, 12 December 2013 (EET)(
Hamishwillee - Still the same feedback
I fixed the categories and gave the introduction a subedit to improve the English.
Basically though my feedback is the same. This is an interesting filter, but it's value would be much higher if it was created for use with the Imaging SDK. I'm also more interested in the algorithm and integrating with the SDK than with the specific UI used.
So "high potential", but not yet realised :-)
talk) 02:57, 13 December 2013 (EET)(
WriteableBitmap properties are slow. You should not use them in your loop. You can do something like
var with = bmp.PixelWidth;
var height = bmp.PixelHeight;
var bufferIn = bmp.Pixels;
var bufferOut = bitmap.Pixels;
for(int i= 0;i<height;++i)
for(int j = 0; j < width; ++j)
int index = i*with+j;
bufferOut [index] = bufferIn [index];
talk) 22:23, 14 December 2013 (EET)(
Somnathbanik - Thanks
Thanks for your feedback, I will update the code soon.
talk) 13:27, 15 December 2013 (EET)(
Somnathbanik - The article is been updated
This article is been updated using Nokia Imaging SDK.
talk) 12:45, 17 December 2013 (EET)(
Hamishwillee - Thank you very much
Much more useful now - thanks. Did you update the code example? I suggest you look at Yan's comment - he is pretty much the community expert now days. Also your code doesn't handle exceptions - copy the ND example to do so.
It is up to you, but I'd suggest that you integrate fully and dump your old approach - make the update section the article and move to the top. The UI section isn't all that interesting and can move to the bottom (though keep the images in the introduction.
talk) 01:34, 19 December 2013 (EET)(
Somnathbanik - Feedback has been taken care of
In this article there are two source code. And the new source code with Nokia Imaging SDK takes care of Yan's comment as well. Yes the article has both the old and the new code, but there are two separate projects one of which (...NokiaImagingSDK.zip) has followed Yan's technique.
I will check and will try to come up with more beautiful UI.
talk) 06:01, 19 December 2013 (EET)(
Hamishwillee - I don't mind the UI
Thanks very much for clariification. The problem is not the UI - please leave that alone.
The problem is that in an article like this the UI is pretty much of no interest at all. That is why I'm suggesting you move it to the end - for completeness.
What is interesting is
- your filter
- the ability to reuse it
Which is why it is important that the filter is first and foremost and how to use it is correct.
talk) 06:08, 19 December 2013 (EET)(
Hamishwillee - ... and why the old code is of not much interestBecause now you have something that can be used in a Nokia SDK pipeline, that is the code that most people would use.
talk) 06:10, 19 December 2013 (EET)(
Somnathbanik - Updated
I have updated the article and also the code. So now it uses only Nokia Imaging SDK to detect the edges and also takes care of Yan's comments.
Regarding UI as this is a very simple user interaction I could not come up with any quick improvement, but I am planing to add few more features which will obviously make some space of UI improvement.
talk) 10:47, 19 December 2013 (EET)(