Please note that as of October 24, 2014, the Nokia Developer Wiki will no longer be accepting user contributions, including new entries, edits and comments, as we begin transitioning to our new home, in the Windows Phone Development Wiki. We plan to move over the majority of the existing entries. Thanks for all your past and future contributions.
Talk:Facebook Chat Client for Windows Phone
Arslan-Pervaiz - Some Early Feedback And Suggestions
First of all thanks alot for such a wonderful work done by you in this XMPP library. Its really highly appreciated.
I have some suggestion lists that you can do as per your convenient. 1. As We know all chat clients mostly follow XMPP protocol that is standard. Facebook, Yahoo, MSN, Skype work on XMPP based implementation. Then why not you make this library as generic that can support all social network that supports the XMPP standards.
2. I havent tested yet this library but as per this wiki post and as per my initial understanding you are getting friends online status on start of app once in this even "OnLoadedOnlineFriends : Returns list of online friends" and then friends online status might be not refreshed in later time. Why not you are handling proper "Presence" of user that is basic feature of XMPP that returns you notification message in incoming stanza that user has gone offline or online. I think that will be potential feature of any chat client or library.
3. As this lib is mainly focusing on Facebook and facebook doesnot allow to addSubscription("Add To Buddy List") and delete subscription("Remove From Buddy List") but if you think to make this lib generic then that will also be potential feature of this library.
And Again Keep Rocking With Such Wonderful work and share your knowledge like this. I wish you must try to do some above suggested improvements as there is no such XMPP library available for Windows Phone and you will be the pioneer one to introduce this thing on this platform. That will help other too much.
I will do the test and will share more feedback on this with my results.
talk) 20:53, 19 September 2013 (EEST)(
Somnathbanik - Thanks
Thanks for all your feedback. I will definitely try your points to add in the library. Regarding your point 2 its actually the "Presence". The event "OnLoadedOnlineFriends" gets called when there is any change in any of the user presence and display the list of online friends only. If any user goes offline this event gets called immediately and update the presence list. To be more specific I am filtering the presence and taking only the online presence to a list class.
Try out the library and let me know if you need any changes in this even. We will surely update accordingly.
talk) 22:38, 19 September 2013 (EEST)(
Somnathbanik - OnLoadedOnlineFriendsOnLoadedOnlineFriends gets called when ever there is a change in user presence. The only difference is that it will return you the list of online friends only, if any friends goes offline or online the list gets updated. Like the one we see in default Windows Phone Facebook Chat list, where only online friends are displayed.
talk) 22:59, 19 September 2013 (EEST)(
Arslan-Pervaiz - Enhancement OnLoadedOnlineFriends
Hi Somnath,Thanks for your positive feedback that is much appreciated. I Would love to suggest if you can return all buddy list in this event "OnLoadedOnlineFriends" with status offline and online and all other info of user. Reason is that is default mechanism. Now its Dev responsibility if he wants to show just online then he/she can filter from that list and display or either want to show offline aswell. In context of this facebook app, I would love to have all contacts in my list with offline and online category or what ever the app requirement. Offline contact is needed because you can send message as well on facebook when user is offline. So that will be potential change. And will increase its usability more even by having online and offline contacts messaging.
talk) 09:49, 20 September 2013 (EEST)(
Arslan-Pervaiz - Imporvements Suggestions
I hope you are doing good. I got a chance to explore your XMPP library. Thats really nice. I got some questions and some suggestions aswell.
1. I noticed that you have created 4 separate dll's to make this library I am curious to know that if its XMPP implementation then why not in single dll instead of dependency of four different dll's to implement XMPP. I guess it will be better if everything resides in standalone dll instead chunks of dll. Again its my point of view, You can surely differ from that.
2. Second Thing I have noticed that, You are returning list on this event "OnLoadedOnlineFriends" And the item type is FriendStatusItem. This class is not implementing iNotifypropertyChanged interface. If you implement that it will be good in binding and any change will be notified to UI seamlessly or Instead of Simple List If You Return Observable Collection.
I Will Keep Posting Things On Thats. I Hope You Wont Mind With That. :)Keep Rocking With Good Work.
talk) 20:11, 22 September 2013 (EEST)(
Somnathbanik - Love your suggestions
Give me few days. I will add your suggestions and will update the library by end of this week. And thanks for your interest, please keep posting your feedback.
talk) 08:10, 23 September 2013 (EEST)(
Somnathbanik - New Release
Please check the new release. Some of your points has been taken care of.
talk) 16:46, 4 October 2013 (EEST)(
Hamishwillee - Very cool, but needs some clarification
OK, so I'm impressed :-) Great initiative to address the needs of the community and go do this.
The weakness in this article is the introduction. What I think you've done is:
- created a "Facebook Chat clients libary" that implements the Jabber/XMPP service" - correct?
- you've named this FacebookChat Library, and its in a namespace XFacebook, with class name static IXFacebook iXFacebook. Correct? (note, I think "static IXFacebook iXFacebook" might then be a typo?
- This library can be used to chat, but you first need to authenticate. The article shows how to authenticate and use the library. Correct?
The problem is that its not clear where this library comes from in the introduction, so the article sounds like its about authentication, when it is also about using the library, or at least that is what I think. If you can confirm that in a comment I can tidy this up quite easily.
I would probably follow the introduction with the explanation of the what the library offers (ie the API reference you added). I would also add information about licensing of the library (ideally BSD or MIT) - even better, host on github and make this clear there.
Otherwise, as I say, excellent.
Regards HamishPS Sorry it took me a while to get to this. A week off followed by a week catchup :-0
talk) 09:12, 7 October 2013 (EEST)(
Somnathbanik - You got things right
You are right!
- This article is not focusing on Facebook Authentication rather implementing Facebook Chat client using the library which uses Jabber/XMPP service, so I just added two Facebook Authentication links in the article other than explaining the complete authentication process.
- As this library supports X-FACEBOOK platform so I named it as XFacebook as its namespace.
Please share more feedback so that we can update the library with more features. And please feel free to make any change in the article you want :-)
talk) 10:32, 7 October 2013 (EEST)(
Hamishwillee - Great/Subedited
Thanks. OK, I have subedited to restructure. Introduction now says what this actually delivers, and I've moved the authentication information down to its own section. Please check that this is still all accurate - ie does say what you meant it to say.
Now that's done, some "suggestions for improvement" - very minor!
- Firstly, naming, you might want to rename things like "FacebokKey" to FacebookKey
- Do you intend others to use this? If so, then the ND site terms and conditions are not very permissive. Are you OK to apply MIT or BSD licensing? If so, this can be done by stating the licening in a license.txt in your zip uploaded.
- Great to host this on github then you would have proper ticketing system (or codeplex)
Anyway, let me know what you think.
talk) 13:47, 7 October 2013 (EEST)(
Somnathbanik - Thanks for edit
- I don't mind if others are interested to use this library and share feedback to improve it.
- Regarding licensing; I want to make it free to use with what ever license fits on it.
- What text should I write in license.txt file, as I have never done any licensing stuff before it would be nice if you could help me.
- I am OK hosting the library on github or codeplex.
talk) 14:08, 7 October 2013 (EEST)(
Arslan-Pervaiz - More Feedbacks
I have look more deeper on this library. I found some more things. I have some more suggestions.
1. You are returning all the list when its populated fully so it will take bit time. So Better approach and practice is to send presence packet one by one So user add them in list when he got that.
2. You are fetching the User Image from Facebook separately instead of getting from vCard of user. So I would recommond you get Image From vCard Rather Than Extra WebHit For UserImage.
3. You Can Also Returns The vCard in Presence that is always with in it so we can get image of user to show on chat Page.
4. Then I will agree himish if you will disclose your source publicly under GPL, BSD then any one can user as per requirement and can share patches and enhancement based on your library.Happy Coding, Keep Rocking
talk) 20:37, 7 October 2013 (EEST)(
Hamishwillee - Licencing
What you want is a permissive free license. The two licenses that most people point to are MIT and BSD. They have minor differences and I suggest you check the wikipedia pages because they explain the main differences. Mostly these are just minor extra terms about when the license.txt needs to be included/mentioned (ie with binaries and source, or just with source) and one of the BSD variants also explicity prohibits your name being used as part of the deriving app's promotion. Personally I like MIT.
To use you just copy the license you like into a text file, name it license.txt and put in the root of your zip file. In the article itself I'd make a comment that the article and associated code example is licenced under BSD.
Enough to go on with?
Regards HHope you do create a project - if you do, then I'd link to that from the article too. Remember to keep the license consistent in both places.
talk) 04:49, 8 October 2013 (EEST)(
Abhisinghal1087 - online friends not visiblei deployed this app to my lumia 720, i was able to log in into my account but the app isnt showing any online friend, once it showed a friend, i tapped his name, bt when the chat opened it was some other friend. what is going wrong?
talk) 14:55, 11 January 2014 (EET)(
Somnathbanik - download version 1.1
Please download the last version (version 1.1) of the library and replace it in your project. It should be all fine.
talk) 17:28, 11 January 2014 (EET)(